Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mesh): MADR for disabling default policy creation #6481

Merged
merged 3 commits into from
May 9, 2023

Conversation

johnharris85
Copy link
Contributor

@johnharris85 johnharris85 commented Apr 5, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(mesh): allow disabling default policy creation

Signed-off-by: John Harris <john@johnharris.io>
@johnharris85 johnharris85 requested review from a team, bartsmykla and lukidzi and removed request for a team April 5, 2023 23:32
Signed-off-by: John Harris <john@johnharris.io>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.
I'd be interested to understand the behaviour if I update this after the mesh creation. Does it delete/create/update default policies? Sounds like now instead of having the defaults component this should just be part of the mesh controller.

docs/madr/decisions/024-disable-default-policies.md Outdated Show resolved Hide resolved
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/madr/decisions/024-disable-default-policies.md Outdated Show resolved Hide resolved
docs/madr/decisions/024-disable-default-policies.md Outdated Show resolved Hide resolved
Signed-off-by: John Harris <john@johnharris.io>
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont merged commit 4082cfe into kumahq:master May 9, 2023
@bartsmykla bartsmykla deleted the default-policies-madr branch May 9, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants