Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MeshRetry): guard against multiple previous priorities #6496

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

johnharris85
Copy link
Contributor

Checklist prior to review

Adds validation for the case where someone specifies OmitPreviousPriorities more than once. This wouldn't error today, but might result in unexpected behavior (we'll always just use the last one specified in the list).

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: John Harris <john@johnharris.io>
@johnharris85 johnharris85 requested review from a team, bartsmykla and lobkovilya and removed request for a team April 7, 2023 15:36
@slonka slonka merged commit ff98483 into kumahq:release-2.2 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants