Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker/tests): update container structure tests #6621

Merged

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Apr 26, 2023

The entrypoint for kumactl image changed. I also adjusted iptables check in kuma-init container structure test and removed check if iptables is "legacy" or not as it's irrelevant.

xref: #6596

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) -- this PR contains test changes
  • Do you need to update UPGRADE.md? -- we don't
  • Does it need to be backported according to the backporting policy? -- it doesn't
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

The entrypoint for kumactl image changed. I also adjusted
iptables check in kuma-init container structure test and removed
check if iptables is "legacy" or not as it's irrelevant.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested review from michaelbeaumont, slonka and a team April 26, 2023 04:16
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wasn't this caught on the original PR?

@bartsmykla
Copy link
Contributor Author

bartsmykla commented Apr 26, 2023

Why wasn't this caught on the original PR?

PR was opened before container structure tests were merged, so it didn't run these tests

@bartsmykla bartsmykla enabled auto-merge (squash) April 26, 2023 04:19
@bartsmykla bartsmykla merged commit 7a4300b into kumahq:master Apr 26, 2023
@bartsmykla bartsmykla deleted the ci/update-container-structure-tests branch April 26, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants