Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): multitenancy adjustments #6705

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

This PR introduces a couple of multitenancy improvements:

  • Simplify interfaces
    • Removed HashingFunc. This is IMHO confusing. It's better to say that some things are tenant aware even if there is a single tenant in Kuma
    • Renamed Tenant to Tenants as it's imho confusing to have Tenant interface with method GetAllId() . Renamed TenantFn() to Tenants() in Runtime obj.
    • Introduce GetID() to Tenants so other implementations can fail if a tenant is missing.
  • Add option to skip creating default tenant aware resources if tenants are managed in other way
  • Introduce overridable global tenant and use it explicitly in components that are not tenant aware. Using it explicitly makes it easier to require tenant in other places.
  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, Automaat and bartsmykla and removed request for a team May 8, 2023 12:00
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the feat/multitenancy-adjustments branch from c747661 to 091f04f Compare May 8, 2023 12:19
Copy link
Contributor

@lukidzi lukidzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and simpler!

@jakubdyszkiewicz jakubdyszkiewicz merged commit bf782b0 into kumahq:master May 8, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/multitenancy-adjustments branch May 8, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants