Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): validate zone name on install #6739

Merged
merged 1 commit into from
May 15, 2023
Merged

feat(helm): validate zone name on install #6739

merged 1 commit into from
May 15, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 10, 2023

Checklist prior to review

@mmorel-35 mmorel-35 marked this pull request as ready for review May 11, 2023 08:01
@mmorel-35 mmorel-35 requested review from a team, michaelbeaumont and Automaat and removed request for a team May 11, 2023 08:01
@mmorel-35 mmorel-35 marked this pull request as draft May 11, 2023 14:33
@mmorel-35 mmorel-35 marked this pull request as ready for review May 12, 2023 16:23
@mmorel-35 mmorel-35 marked this pull request as draft May 12, 2023 21:49
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review May 13, 2023 08:21
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this one @mmorel-35!

@michaelbeaumont michaelbeaumont changed the title feat(kumactl): validate zone name on control-plane install feat(helm): validate zone name on control-plane install May 15, 2023
@michaelbeaumont michaelbeaumont changed the title feat(helm): validate zone name on control-plane install feat(helm): validate zone name on install May 15, 2023
@michaelbeaumont michaelbeaumont merged commit 397f787 into kumahq:master May 15, 2023
@mmorel-35 mmorel-35 deleted the issues/2685 branch May 15, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate zone name is valid on control-plane install (and startup)
3 participants