Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshGateway): tweak route precedence to match Gateway API #6843

Merged
merged 2 commits into from
May 25, 2023
Merged

fix(MeshGateway): tweak route precedence to match Gateway API #6843

merged 2 commits into from
May 25, 2023

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont
chore(deps): bump gateway-api with conformance fix
4ec212d 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested review from a team, slonka and lukidzi and removed request for a team May 25, 2023 08:01
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) May 25, 2023 08:03
@michaelbeaumont michaelbeaumont disabled auto-merge May 25, 2023 08:15
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label May 25, 2023
@michaelbeaumont michaelbeaumont changed the title chore(deps): bump gateway-api with conformance fix fix(MeshGateway): tweak route precedence to match Gateway API May 25, 2023
@michaelbeaumont
fix(MeshGateway): tweak route precedence to match Gateway API
311966c 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) May 25, 2023 18:01
@michaelbeaumont
Copy link
Contributor Author

Flakiness, at least with Gateway API conformance, seems to be resolved

@michaelbeaumont michaelbeaumont merged commit 313b48f into kumahq:master May 25, 2023
@michaelbeaumont michaelbeaumont deleted the chore/gateway-api branch May 25, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @slonka