Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add possibility to extend secrets for cp in helm charts when reusing kuma charts #6883

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

Automaat
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

…hen reusing kuma charts

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested review from a team, slonka and lukidzi and removed request for a team May 31, 2023 09:28
@Automaat Automaat merged commit c918368 into kumahq:master Jun 1, 2023
@Automaat Automaat deleted the feat/parent_secrets_in_helm branch June 1, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants