Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): add backward compatible reading of virtual outbound from config #7088

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix(kuma-cp): add backward compatible reading of virtual outbound from config #7088

merged 1 commit into from
Jun 22, 2023

Conversation

Automaat
Copy link
Contributor

…m config

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat
fix(kuma-cp): add backward compatible reading of virtual outbound fro…
fd17992 
…m config

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jun 22, 2023
@michaelbeaumont michaelbeaumont changed the title fix(kuma-cp): add backward compatible reading of virtual outbound fro… fix(kuma-cp): add backward compatible reading of virtual outbound from config Jun 22, 2023
@Automaat Automaat merged commit 3fdf42b into kumahq:release-2.3 Jun 22, 2023
@Automaat Automaat deleted the fix/tag_first_vo_fallback branch June 22, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Automaat @michaelbeaumont @slonka