Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): better xds metrics #7208

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

This PR adds labels to xds_generation metric.

result label:

  • skip - whenever we decide that we don't need to generate config (mesh hash did not change)
  • generated - whenever we generated config, but it was the same
  • changed - whenever we generated config and the config was actually different

I also added label of proxy type, because we don't have mesh hash protection for zone ingress and egress so it would be impossible to track how many times XDS was really generated.

This is useful because

  • We can track if the environment is stable, a counter of generated or changed is not incremented.
  • We can check generated metrics to see if we can maybe do a better job on detecting if we need to even generate XDS config.

This change is backwards compatible with current dashboards with one small exception - previously we were observing the metrics on .Sync error, but we should not do this. We have a separate metric for tracking errors, so I fixed this.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner July 7, 2023 13:03
@jakubdyszkiewicz jakubdyszkiewicz requested review from Automaat and lobkovilya and removed request for a team July 7, 2023 13:03
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@lobkovilya lobkovilya merged commit 8c09d6f into kumahq:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants