Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): put metadata xds callbacks before sync #7230

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix(kuma-cp): put metadata xds callbacks before sync #7230

merged 1 commit into from
Jul 13, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Jul 13, 2023 •
edited
Loading

For OnStreamOpen, they're run in this order and OnStreamClosed, in the reverse. We want to have metadata before syncing and want to delete metadata after syncing so this order makes sense.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lobkovilya
fix(kuma-cp): change XDS callbacks order
0a3e8da 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jul 13, 2023
@michaelbeaumont michaelbeaumont changed the title fix(kuma-cp): change XDS callbacks order fix(kuma-cp): put metadata callbacks before sync Jul 13, 2023
@michaelbeaumont michaelbeaumont changed the title fix(kuma-cp): put metadata callbacks before sync fix(kuma-cp): put metadata xds callbacks before sync Jul 13, 2023
@michaelbeaumont michaelbeaumont mentioned this pull request Jul 12, 2023
Merged
7 tasks
@lobkovilya lobkovilya marked this pull request as ready for review July 13, 2023 13:45
@lobkovilya lobkovilya requested a review from a team as a code owner July 13, 2023 13:45
@lobkovilya lobkovilya requested review from Automaat and lukidzi and removed request for a team July 13, 2023 13:45
@lobkovilya lobkovilya merged commit 91e9f2f into kumahq:master Jul 13, 2023
@lobkovilya lobkovilya deleted the fix/change-xds-callbacks-order branch July 13, 2023 13:45
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023 •
edited
Loading

backporting to release-2.3 with action

backporting to release-1.8 with action
backporting to release-2.1 with action
backporting to release-2.0 with action

@github-actions
Copy link
Contributor

backporting to release-2.2 with action

@kumahq kumahq bot mentioned this pull request Jul 13, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lobkovilya @kumahq
fix(kuma-cp): put metadata xds callbacks before sync (#7230)
bfdd611 
fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Jul 13, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lobkovilya @kumahq
fix(kuma-cp): put metadata xds callbacks before sync (#7230)
360aef7 
fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Jul 13, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lobkovilya @kumahq
fix(kuma-cp): put metadata xds callbacks before sync (#7230)
507d203 
fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Jul 13, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lobkovilya @kumahq
fix(kuma-cp): put metadata xds callbacks before sync (#7230)
d578b40 
fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Jul 13, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lobkovilya @kumahq
fix(kuma-cp): put metadata xds callbacks before sync (#7230)
e46bc44 
fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
michaelbeaumont pushed a commit that referenced this pull request Jul 13, 2023
@kumahq @lobkovilya
fix(kuma-cp): put metadata xds callbacks before sync (backport of #7230…
bb219c6 
…) (#7247)

fix(kuma-cp): put metadata xds callbacks before sync (#7230)

fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
michaelbeaumont pushed a commit that referenced this pull request Jul 13, 2023
@kumahq @lobkovilya
fix(kuma-cp): put metadata xds callbacks before sync (backport of #7230…
572fe84 
…) (#7245)

fix(kuma-cp): put metadata xds callbacks before sync (#7230)

fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
michaelbeaumont pushed a commit that referenced this pull request Jul 13, 2023
@kumahq @lobkovilya
fix(kuma-cp): put metadata xds callbacks before sync (backport of #7230…
98d3e9c 
…) (#7244)

fix(kuma-cp): put metadata xds callbacks before sync (#7230)

fix(kuma-cp): change XDS callbacks order

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobkovilya @michaelbeaumont