feat(kuma-cp): allow to disable resources count metrics #7304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we are reporting metrics for each resource name and the number of the resources. When we introduced multitenancy we also increased the cardinality of the metrics. In case of many tenants metrics can be really expensive. Now we are able to disable it. Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
requested review from
jakubdyszkiewicz and
lobkovilya
and removed request for
a team
lahabana
approved these changes
Jul 19, 2023
michaelbeaumont
changed the title
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
Currently, we are reporting metrics for each resource name with the number of resources. When we introduced multitenancy we also increased the cardinality of the metrics. In the case of many tenants, metrics can be really expensive. Now we are able to disable it because i feel like there is no point to report aggregated metrics with the count of all the resources.
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?