Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): handle advertised address in zone ingress #7332

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix(kuma-cp): handle advertised address in zone ingress #7332

merged 1 commit into from
Jul 24, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

Fix #6545

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
fix(kuma-cp): handle advertisied address in zone ingress
6f9c601 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner July 24, 2023 13:25
@jakubdyszkiewicz jakubdyszkiewicz requested review from michaelbeaumont and lukidzi and removed request for a team July 24, 2023 13:25
@lahabana lahabana changed the title fix(kuma-cp): handle advertisied address in zone ingress fix(kuma-cp): handle advertised address in zone ingress Jul 24, 2023
@jakubdyszkiewicz jakubdyszkiewicz merged commit 26b7e68 into kumahq:master Jul 24, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the advertisied-address-ingress branch July 24, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingress proxy does not respect the configured advertisedAddress of a dataplane
3 participants
@jakubdyszkiewicz @michaelbeaumont @lukidzi