Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update CoreDNS to v1.11.0 #7493

Merged
merged 1 commit into from
Aug 9, 2023
Merged

chore(deps): update CoreDNS to v1.11.0 #7493

merged 1 commit into from
Aug 9, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Aug 8, 2023 •
edited by lahabana
Loading

Checklist prior to review

Changelog: chore(deps): bump CoreDNS from v1.10.1 to v1.11.0

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont
chore(deps): update CoreDNS to v1.11.0
3dac8ac 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner August 8, 2023 16:00
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz and Automaat and removed request for a team August 8, 2023 16:00
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) August 8, 2023 16:15
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Aug 8, 2023
@michaelbeaumont michaelbeaumont merged commit 0889d86 into kumahq:master Aug 9, 2023
@michaelbeaumont michaelbeaumont deleted the build/coredns-1.11 branch August 9, 2023 10:20
@lukidzi
Copy link
Contributor

lukidzi commented Aug 9, 2023

Does it need backport?

@michaelbeaumont
Copy link
Contributor Author

IMO we should wait a bit before backporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @lukidzi