Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update CoreDNS to v1.11.1 #7523

Merged
merged 1 commit into from
Aug 16, 2023
Merged

chore(deps): update CoreDNS to v1.11.1 #7523

merged 1 commit into from
Aug 16, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Aug 16, 2023 •
edited by lahabana
Loading

Checklist prior to review

Changelog: chore(deps): bump CoreDNS from v1.11.0 to v1.11.1

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont
chore(deps): update CoreDNS to v1.11.1
fc04185 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner August 16, 2023 12:36
@michaelbeaumont michaelbeaumont requested review from lobkovilya and lukidzi and removed request for a team August 16, 2023 12:36
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) August 16, 2023 13:35
slonka
slonka reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to do this? - coredns/coredns#6102 (comment)

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Aug 16, 2023 •
edited
Loading

We're already on 1.11.0, this update (very likely) fixes that regression

@michaelbeaumont
Copy link
Contributor Author

It's the reason I didn't backport 1.11.0, but will do so for 1.11.1

@michaelbeaumont michaelbeaumont merged commit 0e4b2af into kumahq:master Aug 16, 2023
@michaelbeaumont michaelbeaumont deleted the chore/coredns-1.11.1 branch August 16, 2023 13:40
@slonka
Copy link
Contributor

slonka commented Aug 16, 2023

Hmm... why didn't autobackport catch this? any ideas @michaelbeaumont ?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

backporting to release-2.0 with action

backporting to release-2.3 with action
backporting to release-1.8 with action
backporting to release-2.1 with action

This was referenced Aug 16, 2023
Merged
Merged
kumahq bot pushed a commit that referenced this pull request Aug 16, 2023
@michaelbeaumont @kumahq
chore(deps): update CoreDNS to v1.11.1 (#7523)
bec5c8a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
kumahq bot pushed a commit that referenced this pull request Aug 16, 2023
@michaelbeaumont @kumahq
chore(deps): update CoreDNS to v1.11.1 (#7523)
71e1f9b 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@kumahq kumahq bot mentioned this pull request Aug 16, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Aug 16, 2023
@michaelbeaumont @kumahq
chore(deps): update CoreDNS to v1.11.1 (#7523)
6c14c85 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
kumahq bot pushed a commit that referenced this pull request Aug 16, 2023
@michaelbeaumont @kumahq
chore(deps): update CoreDNS to v1.11.1 (#7523)
359a493 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Aug 16, 2023
Merged
Merged
kumahq bot pushed a commit that referenced this pull request Aug 16, 2023
@michaelbeaumont @kumahq
chore(deps): update CoreDNS to v1.11.1 (#7523)
2cd68c7 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Aug 16, 2023
@kumahq @michaelbeaumont
chore(deps): update CoreDNS to v1.11.1 (backport of #7523) (#7529)
1d52f11 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Aug 16, 2023
@kumahq @michaelbeaumont
chore(deps): update CoreDNS to v1.11.1 (backport of #7523) (#7531)
70159c0 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Aug 16, 2023
@kumahq @michaelbeaumont
chore(deps): update CoreDNS to v1.11.1 (backport of #7523) (#7532)
079668a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Aug 18, 2023
@michaelbeaumont
chore(deps): update CoreDNS to v1.11.1 (#7523)
1dbb6af 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Aug 23, 2023
@kumahq @michaelbeaumont
chore(deps): update CoreDNS to v1.11.1 (backport of #7523) (#7528)
b8f3711 
* chore(deps): update CoreDNS to v1.11.1 (#7523)
* build: don't pin coredns/alternate

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @slonka