Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): extend ZoneInsight api with information about usage of… #7563

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

Automaat
Copy link
Contributor

… authorization token

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

… authorization token

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested a review from a team as a code owner August 22, 2023 13:37
@Automaat Automaat requested review from bartsmykla and lukidzi and removed request for a team August 22, 2023 13:37
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@bartsmykla
Copy link
Contributor

I'm a little bit out of context here. What is the purpose of including this information in the insight? Is it for the GUI?

@Automaat
Copy link
Contributor Author

I'm a little bit out of context here. What is the purpose of including this information in the insight? Is it for the GUI?

Yes this information is for GUI purposes

@Automaat Automaat merged commit 0e1ce72 into kumahq:master Aug 23, 2023
@Automaat Automaat deleted the feat/extend-zone-insight-api branch August 23, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants