-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kds): set error when KDS clients fails in goroutine #7725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
requested review from
slonka and
Automaat
and removed request for
a team
September 11, 2023 10:04
jakubdyszkiewicz
approved these changes
Sep 14, 2023
backporting to release-2.1 with action |
kumahq bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
This was referenced Sep 25, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
This was referenced Sep 25, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lahabana
changed the title
fix(kuma-cp): set error when KDS clients fails in goroutine
fix(kds): set error when KDS clients fails in goroutine
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
We are using bi-directional GRPC for the communication between zone and global. KDS might fail when trying to connect with the global and because of this, the zone might not be in sync with Global resources. Because of that, we are using a resilient component which is responsible for starting the code again in case of errors. It works well when an error is returned. But the zone code wasn't returning an error and that caused the component to not start again.
I am not sure how to exactly test it yet.
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?