Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kds): set error when KDS clients fails in goroutine #7725

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Sep 8, 2023

Checklist prior to review

We are using bi-directional GRPC for the communication between zone and global. KDS might fail when trying to connect with the global and because of this, the zone might not be in sync with Global resources. Because of that, we are using a resilient component which is responsible for starting the code again in case of errors. It works well when an error is returned. But the zone code wasn't returning an error and that caused the component to not start again.

I am not sure how to exactly test it yet.

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as ready for review September 11, 2023 10:04
@lukidzi lukidzi requested a review from a team as a code owner September 11, 2023 10:04
@lukidzi lukidzi requested review from slonka and Automaat and removed request for a team September 11, 2023 10:04
@lukidzi lukidzi merged commit 71eeaf0 into kumahq:master Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

backporting to release-2.0 with action

backporting to release-2.2 with action
backporting to release-2.3 with action
backporting to release-2.4 with action

@github-actions
Copy link
Contributor

backporting to release-2.1 with action

kumahq bot pushed a commit that referenced this pull request Sep 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 25, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 25, 2023

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 25, 2023

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 25, 2023

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi pushed a commit that referenced this pull request Sep 25, 2023
… of #7725) (#7834)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi pushed a commit that referenced this pull request Sep 25, 2023
… of #7725) (#7833)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi pushed a commit that referenced this pull request Sep 25, 2023
… of #7725) (#7832)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi pushed a commit that referenced this pull request Sep 25, 2023
… of #7725) (#7830)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi pushed a commit that referenced this pull request Sep 25, 2023
… of #7725) (#7831)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lahabana lahabana changed the title fix(kuma-cp): set error when KDS clients fails in goroutine fix(kds): set error when KDS clients fails in goroutine Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KDS] When clients try to reconnect and there is error connection is broken
2 participants