Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): better error handling #7868

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Sep 26, 2023

Checklist prior to review

  • Do not propagate errors to zone
  • When kdsSyncClient errors out. There was a situation when KDS component could not be restarted, because DeltaStreamHandler swallows errors.
  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review September 26, 2023 11:16
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 26, 2023 11:16
@jakubdyszkiewicz jakubdyszkiewicz requested review from michaelbeaumont and lobkovilya and removed request for a team September 26, 2023 11:16
@jakubdyszkiewicz jakubdyszkiewicz merged commit 3ab585c into kumahq:master Sep 26, 2023
10 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/kds-error-handling branch September 26, 2023 11:52
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

backporting to release-2.3 with action

backporting to release-2.0 with action
backporting to release-2.4 with action
backporting to release-2.1 with action

kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot pushed a commit that referenced this pull request Sep 26, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz pushed a commit that referenced this pull request Sep 26, 2023
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants