ci: disable goconst lint

kunitsucom · Jan 3, 2024 · 840f742 · 840f742
1 parent 0af79f6
commit 840f742
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 22 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -13,6 +13,7 @@ linters:
     - exhaustruct # https://github.com/GaijinEntertainment/go-exhaustruct
     - exhaustivestruct # https://github.com/mbilski/exhaustivestruct
     - gci # unnecessary
+    - goconst # unnecessary
     - godox # unnecessary
     - golint # deprecated https://github.com/golang/lint
     - gomnd # https://github.com/tommy-muehle/go-mnd

diff --git a/exp/database/sql/ddl/cockroachdb/ddl_index_create.go b/exp/database/sql/ddl/cockroachdb/ddl_index_create.go
@@ -33,11 +33,11 @@ func (s *CreateIndexStmt) String() string {
 	}
 	str += "CREATE "
 	if s.Unique {
-		str += "UNIQUE " //nolint:goconst
+		str += "UNIQUE "
 	}
-	str += "INDEX " //nolint:goconst
+	str += "INDEX "
 	if s.IfNotExists {
-		str += "IF NOT EXISTS " //nolint:goconst
+		str += "IF NOT EXISTS "
 	}
 	str += s.Name.String() + " ON " + s.TableName.String() + " (" + stringz.JoinStringers(", ", s.Columns...) + ");\n"
 	return str
@@ -46,11 +46,11 @@ func (s *CreateIndexStmt) String() string {
 func (s *CreateIndexStmt) StringForDiff() string {
 	str := "CREATE "
 	if s.Unique {
-		str += "UNIQUE " //nolint:goconst
+		str += "UNIQUE "
 	}
-	str += "INDEX " //nolint:goconst
+	str += "INDEX "
 	if s.IfNotExists {
-		str += "IF NOT EXISTS " //nolint:goconst
+		str += "IF NOT EXISTS "
 	}
 	str += s.Name.StringForDiff() + " ON " + s.TableName.StringForDiff() + " ("
 	for i, c := range s.Columns {

diff --git a/exp/database/sql/ddl/cockroachdb/ddl_index_drop.go b/exp/database/sql/ddl/cockroachdb/ddl_index_drop.go
@@ -29,7 +29,7 @@ func (s *DropIndexStmt) String() string {
 	}
 	str += "DROP INDEX "
 	if s.IfExists {
-		str += "IF EXISTS " //nolint:goconst
+		str += "IF EXISTS "
 	}
 	str += s.Name.String() + ";\n"
 	return str

diff --git a/exp/database/sql/ddl/cockroachdb/ddl_table.go b/exp/database/sql/ddl/cockroachdb/ddl_table.go
@@ -54,7 +54,7 @@ func (c *PrimaryKeyConstraint) GoString() string { return internal.GoString(*c)
 func (c *PrimaryKeyConstraint) String() string {
 	var str string
 	if c.Name != nil {
-		str += "CONSTRAINT " + c.Name.String() + " " //nolint:goconst
+		str += "CONSTRAINT " + c.Name.String() + " "
 	}
 	str += "PRIMARY KEY"
 	str += " (" + stringz.JoinStringers(", ", c.Columns...) + ")"
@@ -64,7 +64,7 @@ func (c *PrimaryKeyConstraint) String() string {
 func (c *PrimaryKeyConstraint) StringForDiff() string {
 	var str string
 	if c.Name != nil {
-		str += "CONSTRAINT " + c.Name.StringForDiff() + " " //nolint:goconst
+		str += "CONSTRAINT " + c.Name.StringForDiff() + " "
 	}
 	str += "PRIMARY KEY"
 	str += " ("
@@ -188,7 +188,7 @@ func (c *CheckConstraint) String() string {
 	if c.Name != nil {
 		str += "CONSTRAINT " + c.Name.String() + " "
 	}
-	str += "CHECK" //nolint:goconst
+	str += "CHECK"
 	str += " (" + stringz.JoinStringers(" ", c.Expr...) + ")"
 	return str
 }
@@ -310,7 +310,7 @@ func (d *Default) String() string {
 		return ""
 	}
 	if d.Value != nil {
-		return "DEFAULT " + d.Value.String() //nolint:goconst
+		return "DEFAULT " + d.Value.String()
 	}
 	return ""
 }

diff --git a/exp/database/sql/ddl/postgres/ddl_index_create.go b/exp/database/sql/ddl/postgres/ddl_index_create.go
@@ -33,11 +33,11 @@ func (s *CreateIndexStmt) String() string {
 	}
 	str += "CREATE "
 	if s.Unique {
-		str += "UNIQUE " //nolint:goconst
+		str += "UNIQUE "
 	}
-	str += "INDEX " //nolint:goconst
+	str += "INDEX "
 	if s.IfNotExists {
-		str += "IF NOT EXISTS " //nolint:goconst
+		str += "IF NOT EXISTS "
 	}
 	str += s.Name.String() + " ON " + s.TableName.String() + " (" + stringz.JoinStringers(", ", s.Columns...) + ");\n"
 	return str
@@ -46,11 +46,11 @@ func (s *CreateIndexStmt) String() string {
 func (s *CreateIndexStmt) StringForDiff() string {
 	str := "CREATE "
 	if s.Unique {
-		str += "UNIQUE " //nolint:goconst
+		str += "UNIQUE "
 	}
-	str += "INDEX " //nolint:goconst
+	str += "INDEX "
 	if s.IfNotExists {
-		str += "IF NOT EXISTS " //nolint:goconst
+		str += "IF NOT EXISTS "
 	}
 	str += s.Name.StringForDiff() + " ON " + s.TableName.StringForDiff() + " ("
 	for i, c := range s.Columns {

diff --git a/exp/database/sql/ddl/postgres/ddl_index_drop.go b/exp/database/sql/ddl/postgres/ddl_index_drop.go
@@ -29,7 +29,7 @@ func (s *DropIndexStmt) String() string {
 	}
 	str += "DROP INDEX "
 	if s.IfExists {
-		str += "IF EXISTS " //nolint:goconst
+		str += "IF EXISTS "
 	}
 	str += s.Name.String() + ";\n"
 	return str

diff --git a/exp/database/sql/ddl/postgres/ddl_table.go b/exp/database/sql/ddl/postgres/ddl_table.go
@@ -42,7 +42,7 @@ func (c *PrimaryKeyConstraint) GoString() string { return internal.GoString(*c)
 func (c *PrimaryKeyConstraint) String() string {
 	var str string
 	if c.Name != nil {
-		str += "CONSTRAINT " + c.Name.String() + " " //nolint:goconst
+		str += "CONSTRAINT " + c.Name.String() + " "
 	}
 	str += "PRIMARY KEY"
 	str += " (" + stringz.JoinStringers(", ", c.Columns...) + ")"
@@ -52,7 +52,7 @@ func (c *PrimaryKeyConstraint) String() string {
 func (c *PrimaryKeyConstraint) StringForDiff() string {
 	var str string
 	if c.Name != nil {
-		str += "CONSTRAINT " + c.Name.StringForDiff() + " " //nolint:goconst
+		str += "CONSTRAINT " + c.Name.StringForDiff() + " "
 	}
 	str += "PRIMARY KEY"
 	str += " ("
@@ -171,7 +171,7 @@ func (c *CheckConstraint) String() string {
 	if c.Name != nil {
 		str += "CONSTRAINT " + c.Name.String() + " "
 	}
-	str += "CHECK" //nolint:goconst
+	str += "CHECK"
 	str += " (" + stringz.JoinStringers(" ", c.Expr...) + ")"
 	return str
 }
@@ -292,7 +292,7 @@ func (d *Default) String() string {
 		return ""
 	}
 	if d.Value != nil {
-		return "DEFAULT " + d.Value.String() //nolint:goconst
+		return "DEFAULT " + d.Value.String()
 	}
 	return ""
 }