fix Wrong return value (#675)

Signed-off-by: Gidi233 <qpbtyfh@gmail.com>
kurator-dev · Aug 26, 2024 · 7eef581 · 7eef581
1 parent 7311b1a
commit 7eef581
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/fleet-manager/fleet_plugin_metric.go b/pkg/fleet-manager/fleet_plugin_metric.go
@@ -207,10 +207,10 @@ func (f *FleetManager) syncObjStoreSecret(ctx context.Context, fleetCluster *Fle
 			},
 		}, metav1.CreateOptions{})
 		if err != nil {
-			return nil
+			return err
 		}
 	} else if err != nil {
-		return nil
+		return err
 	}
 
 	s, err := fleetCluster.Client.KubeClient().CoreV1().Secrets(secret.Namespace).Get(ctx, secret.Name, metav1.GetOptions{})

diff --git a/pkg/plugin/istio/install.go b/pkg/plugin/istio/install.go
@@ -424,7 +424,7 @@ func (p *IstioPlugin) installRemotes(remotePilotAddress string) error {
 		}
 
 		if err := p.createIstioRemoteSecret(currentRemote); err != nil {
-			return nil
+			return err
 		}
 
 		if err := p.createRemoteIstioOperator(currentRemote, remotePilotAddress); err != nil {

diff --git a/pkg/plugin/prometheus/plugin.go b/pkg/plugin/prometheus/plugin.go
@@ -196,7 +196,7 @@ func (p *Plugin) runInstall() error {
 func (p *Plugin) exposePrometheus() error {
 	s, err := p.KubeClient().CoreV1().Services(monitoringNamespace).Get(context.TODO(), promSvcName, metav1.GetOptions{})
 	if err != nil {
-		return nil
+		return err
 	}
 
 	// 2. create elb service for prometheus