Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restore doc and fix restore bug #419

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Oct 28, 2023

What type of PR is this?

/kind bug

/kind documentation

What this PR does / why we need it:

The restoration which based on a schedule type backup leads to incorrect behavior in the program. Therefore, the entire PR has fixed this issue and completed the documentation for How to use Restore

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add restore doc and fix restore bug

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 984c40f
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/653e47af55097900091f4fe8

Signed-off-by: Xieql <xieqianglong@huawei.com>
### Restore from an **Immediate Backup**

- **Use Case**: Responding to sudden data losses or application issues.
- **Referred Backup**: The specific **Immediate Backup** designated by the user.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I donot understand it


- **Use Case**: Responding to sudden data losses or application issues.
- **Referred Backup**: The specific **Immediate Backup** designated by the user.
- **Restore Result**: Restoration from the selected backup into designated clusters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

}

// Fetch the most recent completed backup name if it's a scheduled backup.
veleroScheduleName := generateVeleroResourceName(clusterName, BackupKind, referredBackup.Namespace, referredBackup.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: share with L205

Xieql added 2 commits October 29, 2023 17:36
Signed-off-by: Xieql <xieqianglong@huawei.com>
Signed-off-by: Xieql <xieqianglong@huawei.com>
@Xieql
Copy link
Contributor Author

Xieql commented Oct 29, 2023

/label tide/merge-method-squash

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit c5b9210 into kurator-dev:main Oct 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants