-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add restore doc and fix restore bug #419
Conversation
✅ Deploy Preview for kurator-dev canceled.
|
Signed-off-by: Xieql <xieqianglong@huawei.com>
### Restore from an **Immediate Backup** | ||
|
||
- **Use Case**: Responding to sudden data losses or application issues. | ||
- **Referred Backup**: The specific **Immediate Backup** designated by the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I donot understand it
|
||
- **Use Case**: Responding to sudden data losses or application issues. | ||
- **Referred Backup**: The specific **Immediate Backup** designated by the user. | ||
- **Restore Result**: Restoration from the selected backup into designated clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
} | ||
|
||
// Fetch the most recent completed backup name if it's a scheduled backup. | ||
veleroScheduleName := generateVeleroResourceName(clusterName, BackupKind, referredBackup.Namespace, referredBackup.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: share with L205
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
The restoration which based on a
schedule
type backup leads to incorrect behavior in the program. Therefore, the entire PR has fixed this issue and completed the documentation forHow to use Restore
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: