Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add security team #438

Merged
merged 4 commits into from
Nov 9, 2023
Merged

add security team #438

merged 4 commits into from
Nov 9, 2023

Conversation

LiZhenCheng9527
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Provides specifications for kurator vulnerability submissions

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit d02032c
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/654caaeae8186100088b42e9

@zirain
Copy link
Contributor

zirain commented Nov 8, 2023

/lgtm


- [xuzhonghu@huawei.com](mailto:xuzhonghu@huawei.com)
- [xieqianglong@huawei.com](mailto:xieqianglong@huawei.com)
- [lizhencheng6@huawei.com](mailto:lizhencheng6@huawei.com)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please donot use personal email, will apply a email group

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying for an email group, the content will be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security team is a team consists of different people to handle security issues.
I think it's fine to list team members here, but please make sure people report security issues to a email group.

@@ -0,0 +1,17 @@
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have bug-report here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I think that since we have a security vulnerability submission specification, we should also need a template for the submission content

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug report is a separate issue, no need to couple with vulnerability. It can be linked in developer guide

@@ -0,0 +1,20 @@
## Report a Vulnerability
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the readme

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@kurator-bot kurator-bot removed the lgtm label Nov 8, 2023
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@@ -2,7 +2,7 @@

We sincerely request you to keep the vulnerability information confidential and responsibly disclose the vulnerabilities.

To report a vulnerability, please contact the [Security Team](security-groups.md). You can email the Security Team with the security details and the details expected for [kurator bug report](https://github.com/kurator-dev/kurator/security-team/bug-report.md).
To report a vulnerability, please contact the Security Team: [kurator-security@googlegroups.com](mailto:kurator-security@googlegroups.com). You can email the Security Team with the security details and the details expected for [kurator report](https://github.com/kurator-dev/kurator/community/security/vulnerability-report-template.md).
Copy link
Member

@hzxuzhonghu hzxuzhonghu Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead link, i cannot jump to that.


Owners:

- [hzxuzhonghu](https://github.com/hzxuzhonghu)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- [hzxuzhonghu](https://github.com/hzxuzhonghu)

Members:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add @zirain

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member

I guess you need to rebase on the latest code, i can see the fossa is run on old config

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@kurator-bot kurator-bot removed the lgtm label Nov 9, 2023
@hzxuzhonghu
Copy link
Member

/lgtm

@kurator-bot kurator-bot merged commit c69f98e into kurator-dev:main Nov 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants