site: add feedback in each doc page #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xieql <xieqianglong@huawei.com>
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zirain
reviewed
Nov 18, 2023
| [services.googleAnalytics] | ||
| # Comment out the next line to disable GA tracking. Also disables the feature described in [params.ui.feedback]. | ||
| # "UA-00000000-0" is a placeholder Google Analytics ID, Future integration of actual analytics is straightforward, requiring only an update to the GA ID. | ||
| id = "UA-00000000-0" |
There was a problem hiding this comment.
This doesn't look like a valid id
There was a problem hiding this comment.
yes, it is just a placeholder.
hzxuzhonghu
reviewed
Nov 20, 2023
| @@ -79,3 +79,19 @@ copyright = "The Kurator Authors" | |||
| url = "https://groups.google.com/g/kurator-dev" | |||
| icon = "fa fa-envelope" | |||
| desc = "Kyverno mailing list" | |||
There was a problem hiding this comment.
"Kyverno mailing list"?
we can fix this spelling mistake
hzxuzhonghu
approved these changes
Nov 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Implemented a feedback feature using a placeholder Google Analytics ID. This enables user feedback via GitHub issues, enhancing community engagement. Future integration of actual analytics is straightforward, requiring only an update to the GA ID.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: