Replaced go-scp package #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zirain
reviewed
Nov 22, 2023
docs/go.mod
Outdated
| @@ -1,5 +1,3 @@ | |||
| module kurator.dev/kurator/docs | |||
|
|
|||
| go 1.18 | |||
|
|
|||
| require github.com/google/docsy v0.6.0 // indirect | |||
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
fix-scp-license
branch
from
8370bb1 to
5d1a37f
Compare
|
/lgtm |
hzxuzhonghu
approved these changes
Nov 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
pkg/plugin/join/kubeedge/kubeedge.go use github.com/bramvdbogaerde/go-scp which license is MPL-2.0.
We need to find toolkits that are not MPL-2.0 licences to replace the methods in them.
Which issue(s) this PR fixes:
Fixes #
#463