Removed useless packages from go.mod. #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev canceled.
|
LiZhenCheng9527
changed the title
LiZhenCheng9527
force-pushed
the
update-gomod
branch
from
d60db9e to
c50ac20
Compare
LiZhenCheng9527
force-pushed
the
update-gomod
branch
from
c50ac20 to
abb0b91
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
update-gomod
branch
from
abb0b91 to
215e2ea
Compare
hzxuzhonghu
approved these changes
Nov 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In the previous references to rook, other three-way libraries were introduced. Now that the api design has been changed so that it doesn't depend on rook, you should remove the three-way packages that rook depends on to keep the environment simple
Which issue(s) this PR fixes:
Fixes # #482