Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename fleetCluster to FleetCluster to make it public #485

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Nov 25, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

the fleetCluster struct is used in many controller,
if we want reactor the fleet-manager folder, we have to make it public.
see #481

Signed-off-by: Xieql <xieqianglong@huawei.com>
Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit a2f0670
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/65615d12b32c6a000808778d

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit daf0144 into kurator-dev:main Nov 25, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants