Feat: Single cluster deployment application #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
hzxuzhonghu
reviewed
Aug 26, 2024
pkg/apis/apps/v1alpha1/types.go
Outdated
| @@ -47,6 +47,7 @@ type ApplicationSpec struct { | |||
| SyncPolicies []*ApplicationSyncPolicy `json:"syncPolicies"` | |||
| // Destination defines the destination clusters where the artifacts will be synced. | |||
| // It can be overriden by the syncPolicies' destination. | |||
| // And if both the current field and syncPolicies' destination are empty, the application will be deployed directly in the current cluster. | |||
There was a problem hiding this comment.
To be more accurate, current cluster should be the the cluster where kurator resides
| log.Info("fleet does not exist", "fleet", fleetKey) | ||
| return ctrl.Result{RequeueAfter: fleetmanager.RequeueAfter}, nil | ||
| var fleet *fleetapi.Fleet | ||
| if fleetKey.Name != "" { |
There was a problem hiding this comment.
fleet is used here
hzxuzhonghu
approved these changes
Aug 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yeyeye2333 <3229833855@qq.com>
Signed-off-by: yeyeye2333 <3229833855@qq.com>
Signed-off-by: yeyeye2333 <3229833855@qq.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow setting the application's destination to a cluster, reducing the operational steps and enabling users to seamlessly use Kurator in a single-cluster, thereby increasing Kurator's flexibility.
Which issue(s) this PR fixes:
Fixes #653
Does this PR introduce a user-facing change?:
The application can be directly deployed to the current host cluster through the following configuration