-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add customizable Metrics Analysis to the rollout API #683
Conversation
Signed-off-by: Gidi233 <qpbtyfh@gmail.com>
Signed-off-by: Gidi233 <qpbtyfh@gmail.com>
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost lgtm
@@ -1616,7 +1616,8 @@ <h3 id="apps.kurator.dev/v1alpha1.Metric">Metric | |||
</td> | |||
<td> | |||
<p>Name of the metric. | |||
Currently supported metric are <code>request-success-rate</code> and <code>request-duration</code>.</p> | |||
Currently supported metric are <code>request-success-rate</code> and <code>request-duration</code>. | |||
When Name is not <code>request-success-rate</code> or <code>request-duration</code>, you need to define the metric rule in CustomMetric.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if request-success-tare and request-duration are not available, you can use the metrics that come with the gateway without customising them.
Both scenarios should be made clear
Signed-off-by: Gidi233 <qpbtyfh@gmail.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
Providing users with customizable Metrics Analysis enables users to flexibly adjust according to different needs and scenarios, ensuring that users can obtain more accurate analysis results that meet specific business applications, thereby improving the operability of the system and the accuracy of data analysis.
Which issue(s) this PR fixes:
Fixes #681
Does this PR introduce a user-facing change?: