Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower packaging #5

Closed
wants to merge 2 commits into from
Closed

Conversation

samuraisam
Copy link
Contributor

Wanted to use this in my app without having to manually manage the dependency, so I've defined a bower package and cleaned up a few other things along the way:

  • removed vendor files (now uses bower to manage dependencies)
  • updated dependency paths on test runner
  • added built version to the to repo for easy bower installability

Hopefully someone else finds this useful!

* removed vendor files (now uses bower to manage dependencies)
* add bower.json
* updated dependency paths on test runner
* added built version to the to repo for easy bower installability
installs bower before the test script
@kurko
Copy link
Owner

kurko commented May 11, 2014

@samuraisam great! Thanks for this PR.

I downloaded your branch locally and ran the tests. They seem to be failing:

Do you mind checking this? I'd love to merge this PR once all tests are green (we can't use TravisCI because PhantomJS has no IndexedDB support).

@kurko
Copy link
Owner

kurko commented May 17, 2014

@samuraisam hey, I fixed those tests locally. Check #6. I'm closing this for now.

@kurko kurko closed this May 17, 2014
@krainboltgreene
Copy link
Contributor

$ bower info ember-indexeddb-adapter
bower not-cached    git://github.com/chlu/ember-indexeddb-adapter.git#*
bower resolve       git://github.com/chlu/ember-indexeddb-adapter.git#*
bower ECMDERR       Failed to execute "git ls-remote --tags --heads git://github.com/chlu/ember-indexeddb-adapter", exit code of #128

Additional error details:
fatal: remote error:
  Repository not found.

@samuraisam
Copy link
Contributor Author

@krainboltgreene it would appear someone else has registered a package of the same name on bower (which is a first-come, first-serve registry). You can use this repository's URL as the package (see bower docs for more info).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants