Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/typehinting #167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/typehinting #167

wants to merge 3 commits into from

Conversation

etanot
Copy link
Contributor

@etanot etanot commented Sep 10, 2021

No description provided.

…code

Type hinted and annotated code block in "Enabling the first few type
annotations" section throws following error message:

$ mypy students2.py
students2.py:10: error: Incompatible types in assignment (expression has type "None", variable has type "str")
students2.py:36: error: Name "std2" already defined on line 32
students2.py:36: error: Name "Student.papers" is not defined
Found 3 errors in 1 file (checked 1 source file)

As written in next paragraph, code block doesn't complain about error
messages. So fixing these error messages and add explanation for it in
next paragraph.
This commit contains following changes:
  - End a complete with period punctuation.
  - End a sentence with colon punctuation, if next sentence contains
    explanation of it.
Fix spell of following words:
  - total (toral -> total).
  - roll (rull -> roll).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant