Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use httplib to get CCAMS working on Linux (via Wine) #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

herver
Copy link

@herver herver commented May 2, 2024

CCAMS was failing to do any HTTP call (right from the start at https://github.com/kusterjs/CCAMS/blob/2.3.1/Helpers.cpp#L12-L16) when using with Euroscope on Linux via Wine, probably because of incompatiblity with Wine's WinInet.h

In order to fix this, I have replaced WinInet usage with httplib and brought in also openssl in order to support SSL/TLS, this increases the DLL size quite a lot unfortunately.

In order to bring in httplib and openssl in an easy way, I have added these external dependencies using vcpkg

I hope this PR can be useful, as this was (for me at least) the last missing link to properly do ATC from Linux (and still be compatible with Windows) 😄

     * use vcpkg for external dependencies
     * bring in httplib and openssl
@pierr3
Copy link

pierr3 commented May 2, 2024

This would be very useful for us on non windows platforms!

@kusterjs
Copy link
Owner

kusterjs commented May 2, 2024

Thank you for your contribution! I will test it a bit before a release.
Maybe I'll release this as a separate version for those using Wine. Still need to think how important the file size is.

@herver
Copy link
Author

herver commented May 2, 2024

Thank you !
Indeed, the DLL will now embed OpenSSL and httplib, here it makes the plugin reach ~3.2MB (which is really big I have to admit )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants