Fix updates to same row leading to incorrect write-write conflict errors #4063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This wasn't exposed due to our testing framework is always going through
prepare
first thenexecute
, which hides the case of two consecutive write transactionsTx
andTy
, whereTy
is executing afterTx
commits, andTy
's start timestamp is same as the commit timestamp ofTx
.Adding a cpp test case for now. Eventually we should also cover the cases of not going through
prepare
interface in our testing framework.Also, removed the useless param
requiredNexTx
, which is always set to false, fromexecuteAndAutoCommitIfNecessaryNoLock
.Fix #4056.