Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generation of grammar files. #4073

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Refactor generation of grammar files. #4073

merged 5 commits into from
Aug 14, 2024

Conversation

mxwli
Copy link
Contributor

@mxwli mxwli commented Aug 13, 2024

Uses md5sum to generate hash of cypher.g4 and keywords.txt
Hash replaces file comparison.
Closes #3683

@mxwli mxwli requested a review from ray6080 August 13, 2024 19:35
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Benchmark Result

Master commit hash: 95d338e22f58405ebc255286f8f6594c01e9f0b0
Branch commit hash: 6d46d4e9e9ead0b4f928f2cdb908dfcf2cf96644

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 677.72 675.04 2.68 (0.40%)
aggregation q28 11728.56 11363.26 365.30 (3.21%)
filter q14 153.27 150.84 2.43 (1.61%)
filter q15 149.07 152.91 -3.84 (-2.51%)
filter q16 329.61 328.89 0.72 (0.22%)
filter q17 475.34 471.30 4.04 (0.86%)
filter q18 1967.46 1941.45 26.01 (1.34%)
fixed_size_expr_evaluator q07 566.34 577.38 -11.04 (-1.91%)
fixed_size_expr_evaluator q08 779.54 779.19 0.35 (0.04%)
fixed_size_expr_evaluator q09 778.66 782.45 -3.79 (-0.48%)
fixed_size_expr_evaluator q10 269.13 267.65 1.48 (0.55%)
fixed_size_expr_evaluator q11 262.59 262.35 0.25 (0.09%)
fixed_size_expr_evaluator q12 261.23 261.64 -0.41 (-0.16%)
fixed_size_expr_evaluator q13 1497.02 1497.71 -0.69 (-0.05%)
fixed_size_seq_scan q23 147.18 146.35 0.82 (0.56%)
join q31 12.39 12.28 0.10 (0.84%)
ldbc_snb_ic q35 752.46 1087.33 -334.88 (-30.80%)
ldbc_snb_ic q36 45.21 41.66 3.55 (8.53%)
ldbc_snb_is q32 11.01 8.51 2.50 (29.35%)
ldbc_snb_is q33 19.19 18.52 0.67 (3.62%)
ldbc_snb_is q34 8.65 8.90 -0.25 (-2.82%)
multi-rel multi-rel-large-scan 2976.40 2849.47 126.93 (4.45%)
multi-rel multi-rel-lookup 64.44 60.15 4.29 (7.13%)
multi-rel multi-rel-small-scan 56.81 63.32 -6.51 (-10.28%)
order_by q25 156.95 153.82 3.13 (2.03%)
order_by q26 474.39 475.39 -1.00 (-0.21%)
order_by q27 1438.21 1434.29 3.92 (0.27%)
scan_after_filter q01 200.08 198.20 1.87 (0.95%)
scan_after_filter q02 185.68 186.16 -0.47 (-0.25%)
shortest_path_ldbc100 q39 149.29 155.86 -6.57 (-4.22%)
var_size_expr_evaluator q03 2084.90 2086.81 -1.92 (-0.09%)
var_size_expr_evaluator q04 2275.41 2263.25 12.16 (0.54%)
var_size_expr_evaluator q05 2644.44 2640.74 3.71 (0.14%)
var_size_expr_evaluator q06 1348.66 1346.79 1.88 (0.14%)
var_size_seq_scan q19 1507.23 1490.11 17.13 (1.15%)
var_size_seq_scan q20 3137.75 3153.42 -15.67 (-0.50%)
var_size_seq_scan q21 2450.70 2455.25 -4.55 (-0.19%)
var_size_seq_scan q22 134.91 134.86 0.04 (0.03%)

@ray6080 ray6080 merged commit 9b61d03 into master Aug 14, 2024
21 checks passed
@ray6080 ray6080 deleted the antlrcopyrefactor branch August 14, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Cypher.g4.copy and keywords.txt.copy file from repo
2 participants