Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some missing algorithm includes #4086

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

benjaminwinger
Copy link
Collaborator

Needed for gcc 14 where they aren't included by other headers implicitly

Needed for gcc 14 where they aren't included by other headers implicitly
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (ec2419f) to head (b3661c5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4086   +/-   ##
=======================================
  Coverage   84.09%   84.10%           
=======================================
  Files        1304     1304           
  Lines       51232    51232           
  Branches     7122     7124    +2     
=======================================
+ Hits        43086    43087    +1     
+ Misses       8000     7998    -2     
- Partials      146      147    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: 6122e06247841e9d4528594a75e686606f925af9
Branch commit hash: 15076d321fbba10c2935da8d74746f9e344ec64d

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 667.82 693.87 -26.05 (-3.75%)
aggregation q28 10918.70 11462.26 -543.56 (-4.74%)
filter q14 146.09 168.52 -22.44 (-13.31%)
filter q15 143.56 167.15 -23.59 (-14.11%)
filter q16 321.20 348.84 -27.64 (-7.92%)
filter q17 466.05 490.06 -24.01 (-4.90%)
filter q18 1983.70 1938.75 44.95 (2.32%)
fixed_size_expr_evaluator q07 555.06 580.53 -25.47 (-4.39%)
fixed_size_expr_evaluator q08 770.43 804.35 -33.93 (-4.22%)
fixed_size_expr_evaluator q09 766.62 803.48 -36.86 (-4.59%)
fixed_size_expr_evaluator q10 255.57 281.17 -25.59 (-9.10%)
fixed_size_expr_evaluator q11 250.54 275.55 -25.01 (-9.07%)
fixed_size_expr_evaluator q12 250.39 274.46 -24.06 (-8.77%)
fixed_size_expr_evaluator q13 1486.22 1517.42 -31.20 (-2.06%)
fixed_size_seq_scan q23 134.27 160.19 -25.92 (-16.18%)
join q31 12.07 13.37 -1.30 (-9.70%)
ldbc_snb_ic q35 762.95 878.14 -115.19 (-13.12%)
ldbc_snb_ic q36 51.33 52.85 -1.52 (-2.88%)
ldbc_snb_is q32 9.53 10.38 -0.85 (-8.22%)
ldbc_snb_is q33 19.83 21.06 -1.23 (-5.85%)
ldbc_snb_is q34 8.52 8.91 -0.39 (-4.39%)
multi-rel multi-rel-large-scan 2893.95 3330.34 -436.40 (-13.10%)
multi-rel multi-rel-lookup 63.44 44.42 19.02 (42.81%)
multi-rel multi-rel-small-scan 52.31 60.90 -8.59 (-14.10%)
order_by q25 146.78 168.88 -22.10 (-13.08%)
order_by q26 463.50 491.05 -27.55 (-5.61%)
order_by q27 1435.05 1439.03 -3.98 (-0.28%)
scan_after_filter q01 189.25 213.60 -24.35 (-11.40%)
scan_after_filter q02 178.23 203.80 -25.57 (-12.55%)
shortest_path_ldbc100 q39 152.41 51.73 100.68 (194.63%)
var_size_expr_evaluator q03 2087.94 2095.75 -7.81 (-0.37%)
var_size_expr_evaluator q04 2298.10 2250.90 47.19 (2.10%)
var_size_expr_evaluator q05 2652.01 2588.52 63.49 (2.45%)
var_size_expr_evaluator q06 1355.37 1367.98 -12.60 (-0.92%)
var_size_seq_scan q19 1502.33 1504.05 -1.72 (-0.11%)
var_size_seq_scan q20 3237.14 3155.84 81.30 (2.58%)
var_size_seq_scan q21 2432.27 2439.45 -7.18 (-0.29%)
var_size_seq_scan q22 134.20 138.49 -4.29 (-3.10%)

@benjaminwinger benjaminwinger merged commit bc30d76 into master Aug 15, 2024
20 of 23 checks passed
@benjaminwinger benjaminwinger deleted the algorithm-gcc-14 branch August 15, 2024 19:13
ray6080 pushed a commit that referenced this pull request Aug 16, 2024
Needed for gcc 14 where they aren't included by other headers implicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants