Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in CorrelatedSubqueryUnnestSolver #4088

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix bug in CorrelatedSubqueryUnnestSolver #4088

merged 2 commits into from
Aug 15, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Aug 15, 2024

Description

See title.

Fixes #4080

Contributor agreement

Copy link

Benchmark Result

Master commit hash: bc30d76d2cbd8ecd6507a55695962460a0817466
Branch commit hash: 9e92fdc35396c54f6db1d192671d36b53686e9db

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 669.96 668.54 1.41 (0.21%)
aggregation q28 10945.63 11730.57 -784.94 (-6.69%)
filter q14 142.78 144.47 -1.69 (-1.17%)
filter q15 144.27 143.05 1.22 (0.85%)
filter q16 320.86 331.58 -10.72 (-3.23%)
filter q17 463.57 471.59 -8.03 (-1.70%)
filter q18 1953.63 1976.14 -22.52 (-1.14%)
fixed_size_expr_evaluator q07 558.47 554.32 4.15 (0.75%)
fixed_size_expr_evaluator q08 765.46 775.07 -9.60 (-1.24%)
fixed_size_expr_evaluator q09 770.29 790.92 -20.63 (-2.61%)
fixed_size_expr_evaluator q10 256.73 260.69 -3.96 (-1.52%)
fixed_size_expr_evaluator q11 251.88 255.86 -3.97 (-1.55%)
fixed_size_expr_evaluator q12 249.90 250.50 -0.60 (-0.24%)
fixed_size_expr_evaluator q13 1484.91 1510.89 -25.98 (-1.72%)
fixed_size_seq_scan q23 134.01 136.11 -2.10 (-1.55%)
join q31 11.78 12.09 -0.31 (-2.53%)
ldbc_snb_ic q35 882.72 897.13 -14.41 (-1.61%)
ldbc_snb_ic q36 55.49 46.46 9.03 (19.45%)
ldbc_snb_is q32 9.73 8.50 1.23 (14.52%)
ldbc_snb_is q33 16.17 13.72 2.45 (17.89%)
ldbc_snb_is q34 8.45 7.86 0.59 (7.46%)
multi-rel multi-rel-large-scan 2839.05 2819.24 19.81 (0.70%)
multi-rel multi-rel-lookup 60.32 56.25 4.06 (7.22%)
multi-rel multi-rel-small-scan 54.90 58.67 -3.77 (-6.42%)
order_by q25 148.50 149.75 -1.25 (-0.84%)
order_by q26 463.67 464.82 -1.15 (-0.25%)
order_by q27 1426.83 1439.58 -12.75 (-0.89%)
scan_after_filter q01 192.13 190.09 2.03 (1.07%)
scan_after_filter q02 177.96 177.98 -0.02 (-0.01%)
shortest_path_ldbc100 q39 48.09 48.82 -0.73 (-1.49%)
var_size_expr_evaluator q03 2090.83 2076.72 14.11 (0.68%)
var_size_expr_evaluator q04 2280.25 2296.88 -16.64 (-0.72%)
var_size_expr_evaluator q05 2632.79 2732.22 -99.43 (-3.64%)
var_size_expr_evaluator q06 1344.50 1356.46 -11.95 (-0.88%)
var_size_seq_scan q19 1487.91 1495.05 -7.14 (-0.48%)
var_size_seq_scan q20 3247.69 3187.65 60.04 (1.88%)
var_size_seq_scan q21 2469.85 2412.56 57.28 (2.37%)
var_size_seq_scan q22 133.32 134.32 -1.00 (-0.75%)

@andyfengHKU andyfengHKU merged commit 2067ffa into master Aug 15, 2024
@andyfengHKU andyfengHKU deleted the fix-4080 branch August 15, 2024 21:12
ray6080 pushed a commit that referenced this pull request Aug 16, 2024
* Fix issue 4080

* Run clang-format

---------

Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Segmentation fault: WITH / OPTIONAL MATCH / WHERE EXISTS
2 participants