Add support for Windows nodes #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvaps
approved these changes
Jan 23, 2023
kvaps
reviewed
Jan 23, 2023
|
Merged. krew index updated. Thank you for contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Windows nodes via a HostProcess pod running PowerShell 7. Doing this relatively cleanly took a little rearranging because certain values needed to be changed based on which operating system was on the node. Whether the node is windows is determined by checking the
kubernetes.io/oslabel on the node object - it defaults back to Linux (with unchanged behavior) unless that label exists and is equal towindows, so this shouldn't cause problems for existing users.This will work on Kubernetes clusters of at least version 1.23 (where HostProcess containers went beta) with nodes running Windows Server 2019 or Windows Server 2022.
I changed the version in the script to 1.7.0 as a best guess, but obviously feel free to modify as needed.