Set correct powershell path for Windows

[feiskyer]

Fix #46

[feiskyer]

@kvaps could you have a look again?

[feiskyer]

kindly ping @kvaps

[elitistphoenix]

I'm not sure if they ever got back to you but it doesn't work for me on my 2019 EKS v1.27 optimised ami nodes

./kubectl-node_shell blah.compute.internal
spawning "pwsh-tc8oco" on "blah.compute.internal"
error: timed out waiting for the condition
pod "pwsh-tc8oco" deleted

[feiskyer]

@elitistphoenix could you check what errors are happening in a different shell while running the node-shell command?

[elitistphoenix]

kubectl node-shell node.compute.internal
spawning "pwsh-7fdemk" on "node.compute.internal"
error: timed out waiting for the condition
pod "pwsh-7fdemk" deleted

same (obviously) for the -- echo 123 one too

[kvaps]

@feiskyer sorry for late reply, and thank you for your contribution.

The main problem is that ghcr.io/feiskyer/winservercore:v1.0 is not official image and I don't want to support it.
This plugin was designed to be very simple, stupid, however adding arch parser would definitely make it better. Thus if Microsoft is not bother building multiarch images, let's go this way then.

I wish to see something like:

os="$(kubectl get node -o jsonpath="{.metadata.labels.kubernetes\.io/os}-{.metadata.labels.kubernetes\.io/arch}" pve1 || exit 1)"

case $os in
  linux-*)
    image="${KUBECTL_NODE_SHELL_IMAGE:-docker.io/library/alpine}"
    name="nsenter"
  ;;
  windows-amd64)
    image="${KUBECTL_NODE_SHELL_IMAGE_WINDOWS_AMD64:-mcr.microsoft.com/powershell}"
    name="pwsh"
  ;;
  windows-arm64)
    image="${KUBECTL_NODE_SHELL_IMAGE_WINDOWS_ARM64:-mcr.microsoft.com/powershell}"
    name="pwsh"
  ;;
esac

[jkroepke]

Since a hostprocess container is spawned, what about https://github.com/microsoft/windows-host-process-containers-base-image ?

Then, the powershell from host can be used.

[feiskyer]

Since a hostprocess container is spawned, what about https://github.com/microsoft/windows-host-process-containers-base-image ?

Thanks for the suggestions. Tried this new image and indeed working well on both 2022 and 2019. PR updated with this base image. PTAL

[kvaps]

LGTM, thank you!