fix: update conversion into OTLP StatisticSet type such that min/max …

…are gauges and sum/count are monotonic counters
kvc0 · Mar 7, 2024 · 8b27c0b · 8b27c0b
1 parent 862ec86
commit 8b27c0b
Showing 1 changed file with 23 additions and 6 deletions.
diff --git a/kotlin/goodmetrics/src/main/kotlin/goodmetrics/downstream/OpentelemetryClient.kt b/kotlin/goodmetrics/src/main/kotlin/goodmetrics/downstream/OpentelemetryClient.kt
@@ -195,13 +195,13 @@ class OpentelemetryClient(
         aggregationWidth: Duration,
         dimensions: Iterable<KeyValue>,
     ): Sequence<Metric> = sequence {
-        yield(statisticSetDataPoint(metric, measurementName, "min", min, timestampNanos, aggregationWidth, dimensions))
-        yield(statisticSetDataPoint(metric, measurementName, "max", max, timestampNanos, aggregationWidth, dimensions))
-        yield(statisticSetDataPoint(metric, measurementName, "sum", sum, timestampNanos, aggregationWidth, dimensions))
-        yield(statisticSetDataPoint(metric, measurementName, "count", count, timestampNanos, aggregationWidth, dimensions))
+        yield(statisticSetDataPointGauge(metric, measurementName, "min", min, timestampNanos, aggregationWidth, dimensions))
+        yield(statisticSetDataPointGauge(metric, measurementName, "max", max, timestampNanos, aggregationWidth, dimensions))
+        yield(statisticSetDataPointCounter(metric, measurementName, "sum", sum, timestampNanos, aggregationWidth, dimensions))
+        yield(statisticSetDataPointCounter(metric, measurementName, "count", count, timestampNanos, aggregationWidth, dimensions))
     }
 
-    private fun statisticSetDataPoint(
+    private fun statisticSetDataPointCounter(
         metricName: String,
         measurementName: String,
         statisticSetComponent: String,
@@ -213,13 +213,30 @@ class OpentelemetryClient(
         name = "${metricName}_${measurementName}_$statisticSetComponent"
         unit = "1"
         sum = sum {
-            isMonotonic = false
+            isMonotonic = true
             // because cumulative is bullshit
             aggregationTemporality = AggregationTemporality.AGGREGATION_TEMPORALITY_DELTA
             dataPoints.add(newNumberDataPoint(value, timestampNanos, aggregationWidth, dimensions))
         }
     }
 
+    private fun statisticSetDataPointGauge(
+        metricName: String,
+        measurementName: String,
+        statisticSetComponent: String,
+        value: Number,
+        timestampNanos: Long,
+        aggregationWidth: Duration,
+        dimensions: Iterable<KeyValue>,
+    ): Metric = metric {
+        name = "${metricName}_${measurementName}_$statisticSetComponent"
+        unit = "1"
+        gauge = gauge {
+            dataPoints.add(newNumberDataPoint(value, timestampNanos, aggregationWidth, dimensions))
+        }
+    }
+
+
     private fun Metrics.asGoofyOtlpMetricSequence(): Sequence<Metric> {
         val otlpDimensions = metricDimensions.values.map { it.asOtlpKeyValue() }
         return sequence {