lightstep histogram lower bound #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightstep requires non-zero histogram buckets to have their intended lower bound present in the data. So this change adds the lower bucket, if missing, with 0 counts. In this way all non-zero ranges will have a lower bound provided, and large ranges where there aren't any observations will be represented by large/sparse 0 ranges rather than explicit 0's for every bucket position between the lowest and highest values. I was told by a Lightstep engineer that this strategy for submitting sparse histograms will work fine with their histogram implementation.
kvc0
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightstep requires non-zero histogram buckets to have their
intended lower bound present in the data. So this change adds
the lower bucket, if missing, with 0 counts. In this way all
non-zero ranges will have a lower bound provided, and large
ranges where there aren't any observations will be represented
by large/sparse 0 ranges rather than explicit 0's for every
bucket position between the lowest and highest values.
I was told by a Lightstep engineer that this strategy for
submitting sparse histograms will work fine with their
histogram implementation.