feat: add new PrescientDimensions type to support edge cases in which dimensions need to be added to both an OTLP resource and each metric #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dimensions need to be added to both an OTLP resource and each metric
kvc0
reviewed
Mar 14, 2024
kotlin/goodmetrics/src/main/kotlin/goodmetrics/downstream/OpentelemetryClient.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
PrescientDimensions.AsMixedResourceDimensionsThis allows users to specify their
PrescientDimensionsto be attached to both an OTLPResourceand each metric datum itself. It unfortunately adds a memory cost for each batch being sent, but this allows users to send metricsto providers who ingest OTLP but may use a different backend (like Prometheus).