add akroma support #1976
add akroma support #1976
Conversation
| @@ -34,6 +34,7 @@ var decryptWalletCtrl = function($scope, $sce, walletService) { | |||
| hwRskPath: "m/44'/137'/0'/0", // first address : m/44'/137'/0'/0/0 | |||
| goPath: "m/44'/6060'/0'/0", // first address: m/44'/6060'/0'/0/0 | |||
| hwEOSClassicPath: "m/44'/2018'/0'/0", // first address: m/44'/2018'/0'/0/0 | |||
| akromaPath: "m/44'/200625'/0'/0", // first address: m/44'/200625'/0'/0/0 | |||
There was a problem hiding this comment.
I'm not a MEW maintainer, but I am following this effort closely and offer some feedback in an effort to speed things along. In keeping with the existing coding style, I'd consider renaming akromaPath to hwAkromaPath
| @@ -112,6 +113,9 @@ var decryptWalletCtrl = function($scope, $sce, walletService) { | |||
| case nodes.nodeTypes.EOSC: | |||
| $scope.HDWallet.dPath = $scope.HDWallet.hwEOSClassicPath; | |||
| break; | |||
| case nodes.nodeTypes.Akroma: | |||
| $scope.HDWallet.dPath = $scope.HDWallet.akromaPath; | |||
There was a problem hiding this comment.
I'd consider renaming akromaPath to hwAkromaPath
| ng-model="HDWallet.dPath" | ||
| type="radio" | ||
| value="{{HDWallet.akromaPath}}"/> | ||
| <span ng-bind="HDWallet.akromaPath"></span> |
There was a problem hiding this comment.
I'd consider renaming akromaPath to hwAkromaPath
There was a problem hiding this comment.
You should edit here also https://github.com/kvhnuke/etherwallet/pull/1976/files#diff-fdb517236c6450fac305b50634838a19R695
Trezor SupportChain ID > 255 support: (merged) Ledger SupportFull 32bit Chain ID support: (merged) Official Ledger Akroma app: (merged) |
|
One dependency remains open for Ledger support: MEW SupportSupport 32 bit Chain ID with the latest Ledger app: |
|
@detroitpro can you resolve the conflict? |
Description
Adding support for Akroma ( akroma.io ). Akroma team is working on native oracle solutions.
Trezor Support