This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
support 32bits chainId with the latest Ledger app #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see LedgerHQ/app-ethereum@8260268 for some larger chainId cases, returned signature v should be recomputed at the client side.
Merged
This was referenced Jul 30, 2018
|
@gre can you please verify these changes? also are these breaking changes? for example will Ledger with older firmware versions will continue work and is it available with latest ledger firmware |
|
This lgtm. It also shouldn't break anything. |
gamalielhere
approved these changes
Aug 1, 2018
This was referenced Aug 10, 2018
mkrufky
added a commit
to mkrufky/etherwallet
that referenced
this pull request
Aug 27, 2018
Enable Ledger Hardware Wallet support for Callisto (CLO)
EIP-155 is now properly working with Callisto!! Tested personally on the Ledger Nano S
homepage : https://callisto.network
block explorer : https://explorer.callisto.network
: https://cloexplorer.org
network statistics : https://clostats.net
slip0044 index : 820
chainId : 820
Callisto has been unable to *safely* work with hardware wallets until the following changes were applied:
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
Callisto has EIP-155 Replay attack protection enabled on their network.
For documentation of this, please see https://github.com/EthereumCommonwealth/go-callisto/blob/CLO/1.0/params/config.go
MyEtherWallet Full 32bit Chain ID support: (merged) MyEtherWallet#1979
Callisto is on Ledger's official roadmap:
https://trello.com/c/AawiAoSM/116-callisto-support
Ledger Nano S Full 32bit Chain ID support: (merged)
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c
Ledger Nano S Callisto (CLO) app: (merged)
LedgerHQ/app-ethereum#22
cc: @yograterol
cc: @project-callisto
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
Apr 16, 2019
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
Apr 20, 2019
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
Apr 27, 2019
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
May 1, 2019
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
May 1, 2019
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
May 20, 2019
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
May 20, 2019
hackmod
added a commit
to EthersocialNetwork/MyEtherWallet
that referenced
this pull request
May 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see LedgerHQ/app-ethereum@8260268
for some larger chainId cases, returned signature v should be recomputed at the client side.
Currently, Ledger returns only
1-bytetruncated signaturev. but it containssignature v bit. so we can recalculate for given chainId byv = chainId * 2 + 35 + signature v bit.