Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to let the user choose the qt style used by the app #2663

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

ctrlaltca
Copy link
Contributor

Fix #2662

@DarthGandalf
Copy link
Member

So the -style command line flag will be ignored?

Any way to only change the default, but still honor the explicit user's config?

@ctrlaltca
Copy link
Contributor Author

So the -style command line flag will be ignored?

Unfortunately yes.

Any way to only change the default, but still honor the explicit user's config?

Should we add an option? This way we could also remove the hardcoded style for gtk3 (#2117).
Hopefully we can get the style from options before the mainwindow get shown to avoid a sudden style change

@AbraxasDMG
Copy link

AbraxasDMG commented Jul 15, 2024

Is the command line switch the only way to apply different style at the moment (no possibility to do it through some config file or environment var)?

If so, KVIrc should also be able to recognize -style cmdline argument and avoid treating it as a server name to which it should connect automatically.

Just realized that this can be prevented if the style argument is provided as follows.
-style=Fusion

Then a new standalone server is not added to the list and automatically attempted to connect to.

… custom Qt Style (like Fusion on Windows, supporting dark mode)
@ctrlaltca ctrlaltca changed the title force the use of Fusion style under windows, supporting dark mode Add an option to let the user choose the qt style used by the app Jul 15, 2024
@ctrlaltca
Copy link
Contributor Author

@DarthGandalf please have a look at the second iteration of this patch, I've changed approach adding a new option in theme->general

@AbraxasDMG once we get this working you won't need to provide the commandline parameter anymore

@DarthGandalf
Copy link
Member

Haven't tested, but seems fine, I guess

Co-authored-by: Alexey Sokolov <alexey+github@asokolov.org>
@ctrlaltca ctrlaltca merged commit f200592 into kvirc:master Jul 15, 2024
5 checks passed
@ctrlaltca ctrlaltca deleted the win_darkmode branch July 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does KVIrc have a dark mode on Windows?
3 participants