Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes to sound module related to autodetect #2669

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

ctrlaltca
Copy link
Contributor

@ctrlaltca ctrlaltca commented Jul 24, 2024

  1. Sound options: don't immediately save changes when sound system gets autodetected.
    Instead of changing the value of KVI_OPTION_STRING(KviOption_stringSoundSystem) inside KviSoundPlayer::detectSoundSystem, return the detected value and let the caller handle it
    fix Settings are changed even when clicking Cancel #2667

  2. If the config-saved sound system is not available anymore, force an autodetect
    fix Automatically autodetect sound system if old one doesn't exist #2668

  3. Fixed the "qt" sound system not working under qt6: the QSoundEffect object was method-local and deleted before the sound actually played.

  4. Prefer the "phonon" sound system if available over the "qt" sound system, since the latter can only play wav files. changed in point 6

  5. Nuke support for Arts (KDE2/3 sound server) and ESD (Gnome sound server before 2009)

  6. Replace QSoundEffect with QMediaPlayer to support more file formats. Adjust the priority of "qt" sound system in autodetect

@ctrlaltca ctrlaltca changed the title Sound options: don't immediately save changes when sound system gets autodetected; fix #2667 Misc fixes to sound module related to autodetect Jul 24, 2024
@DarthGandalf
Copy link
Member

https://doc.qt.io/qt-6/videooverview.html#supported-media-formats says it's not only wav supported

@ctrlaltca
Copy link
Contributor Author

That doc is valid for QMediaPlayer. The doc for QSoundEffect is: https://doc.qt.io/qt-6/audiooverview.html#low-latency-sound-effects
It it doesn't add further dependencies, we could switch to QMediaPlayer anyway

@DarthGandalf
Copy link
Member

It it doesn't add further dependencies, we could switch to QMediaPlayer anyway

Yeah, that would be closer to phonon experience

I'll try this locally before approving

@ctrlaltca
Copy link
Contributor Author

@DarthGandalf : switched to QMediaPlayer, if you want to give it a try

@ctrlaltca ctrlaltca merged commit 1a1db49 into kvirc:master Aug 2, 2024
4 of 5 checks passed
@ctrlaltca ctrlaltca deleted the fix_2667 branch August 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants