-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes to sound module related to autodetect #2669
Conversation
https://doc.qt.io/qt-6/videooverview.html#supported-media-formats says it's not only wav supported |
That doc is valid for QMediaPlayer. The doc for QSoundEffect is: https://doc.qt.io/qt-6/audiooverview.html#low-latency-sound-effects |
Yeah, that would be closer to phonon experience I'll try this locally before approving |
@DarthGandalf : switched to QMediaPlayer, if you want to give it a try |
…can only play wav files)
…ile formats. Adjust the priority of "qt" sound system in autodetect
Sound options: don't immediately save changes when sound system gets autodetected.
Instead of changing the value of
KVI_OPTION_STRING(KviOption_stringSoundSystem)
insideKviSoundPlayer::detectSoundSystem
, return the detected value and let the caller handle itfix Settings are changed even when clicking Cancel #2667
If the config-saved sound system is not available anymore, force an autodetect
fix Automatically autodetect sound system if old one doesn't exist #2668
Fixed the "qt" sound system not working under qt6: the QSoundEffect object was method-local and deleted before the sound actually played.
Prefer the "phonon" sound system if available over the "qt" sound system, since the latter can only play wav files.changed in point 6Nuke support for Arts (KDE2/3 sound server) and ESD (Gnome sound server before 2009)
Replace QSoundEffect with QMediaPlayer to support more file formats. Adjust the priority of "qt" sound system in autodetect