Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Problematic default key bindings #141

Closed
laloch opened this issue Apr 2, 2019 · 9 comments
Closed

Problematic default key bindings #141

laloch opened this issue Apr 2, 2019 · 9 comments

Comments

@laloch
Copy link
Contributor

laloch commented Apr 2, 2019

We have some conflicting default key bindings:

Next tiling layout - Meta + PgUp is used by KWin for "Maximize Window".
Previous tiling layout - Meta + PgDown is used by KWin for "Minimize Window".

Then we have some default shortcuts that do not work on standard US keyboard layout:

Swap with next tile - Meta + Shift + [ - there is no such key. It's Meta + {.
Swap with previous tile - Meta + Shift + ] - there is no such key. It's Meta + }.

@faho
Copy link
Collaborator

faho commented Apr 2, 2019

Yeah, finding keys never was my strong suit.

Any ideas?

I'd also be okay with dropping some shortcuts, at least by default, though I'm not quite sure what happens with old settings after an upgrade?

@piotr-dobrogost
Copy link

Swap with next tile - Meta + Shift + [ - there is no such key. It's Meta + {.

Recently I hit this and tried looking for a KDE bug pertaining to how shortcuts are presented in the UI. It seems that former representation (involving explicit Shift key) feels more natural and should be preferred to the latter representation.

@laloch
Copy link
Contributor Author

laloch commented Apr 2, 2019

@faho

Yeah, finding keys never was my strong suit.
Any ideas?

Yeah, I'm not much of a UX expert either. I have the conflicting keys mapped on Meta + Shift + PgUp.

I'd also be okay with dropping some shortcuts, at least by default

Yes perhaps, but which ones are those you want to cut off? :)

though I'm not quite sure what happens with old settings after an upgrade?

My bet would be that the old shortcuts will be preserved. I'll test it later today.

@piotr-dobrogost

It seems that former representation (involving explicit Shift key) feels more natural and should be preferred to the latter representation.

Agreed. But it's not the matter of preference - the problem is that the "nicer" shortcuts just do not work for me with standard US layout.

@faho
Copy link
Collaborator

faho commented Apr 2, 2019

I have the conflicting keys mapped on Meta + Shift + PgUp.

Yeah, that should work (though I have to admit, Meta + PgUP is a horrible shortcut for maximization, and it'd surprise me if anyone actually used it).

Yes perhaps, but which ones are those you want to cut off? :)

Mostly anything that can be done via KWin's shortcuts should not be in the script, though I've removed most of those already.

"Tile now" is a hack that I don't think is all that useful?

Do we need both "move window up/down/left/right" and "swap tile with next/previous"?

"Toggle Border For All" is basically just "do what KWin does, for all windows", and I don't think it's used often.

@laloch
Copy link
Contributor Author

laloch commented Apr 3, 2019

though I have to admit, Meta + PgUP is a horrible shortcut for maximization, and it'd surprise me if anyone actually used it.

:)) I do! No kidding. On my NB keyboard it even is Meta + Fn + Up and yet I still use it.

"Tile now" is a hack that I don't think is all that useful?

I can imagine that there are users out there who have tiling off by default an only use the script to unclutter their desktops occasionally.

Do we need both "move window up/down/left/right" and "swap tile with next/previous"?

I do personally only use "move window". "Swap tile" is too confusing to my aging brain.

"Toggle Border For All" is basically just "do what KWin does, for all windows", and I don't think it's used often.

Can not tell, since I use regular Breeze decorations without title bars. I don't feel any needs to turn them off.

@faho
Copy link
Collaborator

faho commented Apr 5, 2019

So, I've just tried to change these, and in the process I reset all shortcuts to the defaults, and it doesn't seem to be registering? I updated the script, restarted kwin, ran kbuildsycoca5 for good measure, and all the tiling shortcuts appear unset? Is this broken again? #79?

This is with kwin 5.15.4.

@laloch
Copy link
Contributor Author

laloch commented Apr 5, 2019

I just tested on KWin 5.15.3. Created a new user, logged in, installed the script, ran kbuildsycoca5 and all the shortcuts are assigned. I'll retest with KWin unstable later today.

faho added a commit that referenced this issue Apr 5, 2019
KWin uses that for maximize/minimize. No idea why you'd want to press
that, but that's the way the cookie crumbles.

Fixes #141.
@faho
Copy link
Collaborator

faho commented Apr 5, 2019

Urgh... it doesn't change the defaults for "known" shortcuts. You need to remove the script, remove inactive shortcuts, then reinstall.

@laloch
Copy link
Contributor Author

laloch commented Apr 5, 2019

Mmm, too bad. There's not much we can do about it though, except for mentioning it in the README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants