Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cargo): remove unused features #1

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Owner

@kwonoj kwonoj commented Nov 18, 2022

This PR removes serde-serialize from wasm-bindgen:

For the context, it is depreacted rustwasm/wasm-bindgen#3031 and it is one of the culprit causes tricky circular dependency issue tkaitchuck/aHash#95.

Alternative recommendation is to use serde-wasm-bindgen, which seems already being used and looks like serde-serialize is not being used anyway.

@kwonoj kwonoj closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant