Skip to content

Commit

Permalink
Merge dashpay#6205: fix: only run some GH actions on PR approval, not…
Browse files Browse the repository at this point in the history
… on every comment

2777d30 fix(ci): only run some GH actions on PR approval, not on every comment (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-when-a-pull-request-is-approved

  ## What was done?

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK 2777d30

Tree-SHA512: 183deae1d1b32408bd81962721141e976912b2614a046ab23565537db62fcff7d367331db8ced7cf176dc67adbc18b96e7678b37068f807aaafb1718d55dea70
  • Loading branch information
PastaPastaPasta committed Aug 12, 2024
2 parents 25eef1e + 2777d30 commit 8f7dd9c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/merge-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ permissions:
on:
- push
- pull_request_target
- pull_request_review
- pull_request_review:
types: [submitted]

jobs:
check_merge:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/predict-conflicts.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: "Check Potential Conflicts"
on:
- pull_request_target
- pull_request_review
- pull_request_review:
types: [submitted]

permissions:
contents: read
Expand Down

0 comments on commit 8f7dd9c

Please sign in to comment.