Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icudtl.dat fix #270

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Icudtl.dat fix #270

wants to merge 9 commits into from

Conversation

HinTak
Copy link
Collaborator

@HinTak HinTak commented Oct 1, 2024

Download icudtl.dat in CI, re-enable tests and update README.m130.

Fixes #268

Revert "skip test_Paragraph_init0 on windows for now; investigate later"

This reverts commit 10bf421.
Revert "skia.Unicodes.ICU.Make() returns "None" on windows. Disabling skia.Unicodes tests on windows for the moment."

This reverts commit 01e9fc5.
This reverts commit 39b6e0d.
@HinTak
Copy link
Collaborator Author

HinTak commented Oct 2, 2024

The CI error is

File "<string>", line 1
      'import
            ^
  SyntaxError: EOL while scanning string literal

It is either all the quotes and double quotes, or the length. Probably need to put it in a shell script.

@HinTak
Copy link
Collaborator Author

HinTak commented Oct 3, 2024

Okay, venv is significantly different from just plain running "import skia; ...".

And it is failing on something that used to pass:

================================== FAILURES ===================================
  ____________________________ test_svg_blob_bounds _____________________________
  
  svg_blob = None
  
      def test_svg_blob_bounds(svg_blob):
  >       bounds = svg_blob.bounds()
  E       AttributeError: 'NoneType' object has no attribute 'bounds'
  
  D:\a\skia-python\skia-python\tests\test_font.py:255: AttributeError
  ---------------------------- Captured stderr setup ----------------------------
  SkIcuLoader: datafile missing: C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.8.10\tools\icudtl.dat.
  _____________________ test_fontmgr_custom_svg_blob_bounds _____________________
  
  svgfont_path = 'D:\\a\\skia-python\\skia-python\\skia\\resources\\fonts\\SampleSVG.ttf'
  
      def test_fontmgr_custom_svg_blob_bounds(svgfont_path):
          svgface = skia.FontMgr.New_Custom_Empty().makeFromFile(svgfont_path)
          text = "abcdefgh"
          font = skia.Font(svgface,109)
          svg_blob = skia.TextBlob.MakeFromShapedText(text, font)
  >       bounds = svg_blob.bounds()
  E       AttributeError: 'NoneType' object has no attribute 'bounds'
  
  D:\a\skia-python\skia-python\tests\test_font.py:270: AttributeError
  ============================== warnings summary ===============================

@HinTak
Copy link
Collaborator Author

HinTak commented Oct 3, 2024

Filed the shaper failure upstream: https://issues.skia.org/371224771

@HinTak
Copy link
Collaborator Author

HinTak commented Oct 4, 2024

Started a discussion over at rust-skia rust-skia/rust-skia#1041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skparagraph on windows, and icudtl.dat
1 participant