-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icudtl.dat fix #270
Open
HinTak
wants to merge
9
commits into
kyamagu:main
Choose a base branch
from
HinTak:icudtl.dat-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Icudtl.dat fix #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "skip test_Paragraph_init0 on windows for now; investigate later" This reverts commit 10bf421.
Revert "skia.Unicodes.ICU.Make() returns "None" on windows. Disabling skia.Unicodes tests on windows for the moment." This reverts commit 01e9fc5.
This reverts commit 39b6e0d.
…E_TEST was misleading
The CI error is
It is either all the quotes and double quotes, or the length. Probably need to put it in a shell script. |
Okay, venv is significantly different from just plain running "import skia; ...". And it is failing on something that used to pass:
|
Filed the shaper failure upstream: https://issues.skia.org/371224771 |
Started a discussion over at rust-skia rust-skia/rust-skia#1041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download icudtl.dat in CI, re-enable tests and update README.m130.
Fixes #268