M131 public #272
Open
M131 public #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refining earlier change (kyamagu#214). It turns out that Xvfb's GL behavior on Linux differ depending on whether there is actual graphic hardware or entirely headless. The Apple GL settings works on Xvfb on my computer (AMD Radeon R5 Graphics), but fails in github headless CI. Fixes kyamagu#266
… to canvaskit/0.38.2-6411-g3c64459d5d
….38.2-6682-gf7f63e2604)
Milestone 130 ------------- * Ganesh files have been moved out of include/gpu/ into include/gpu/ganesh/. Shims have been left in place, but clients should migrate to the new paths.
…was never used google/skia@16722e4 Revert "Allow passing multiple node IDs per PDF structure node." This reverts commit 2a016ba. StructureElemementNode::fAdditionalNodeIds is currently unused and appears to never have been used. Change-Id: If2c1aae88909dc3ec701e94008108e2dc02504bb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/905896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
straightforward, and includes #267 .
EDIT: I meant #267. Not 271.