Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage In-App Purchase Localizations and Price Points #133

Conversation

tmarkanov
Copy link
Contributor

No description provided.

tmarkanov and others added 2 commits February 9, 2023 15:37
Co-authored-by: Grzegorz Jakubiak <grzegorz@platogo.com>
Co-authored-by: Grzegorz Jakubiak <grzegorz@platogo.com>
@kyledecot
Copy link
Owner

Thanks for your continued contributions to this repo 🎉 I'm wondering if you could split this PR into two separate PRs. One for the added endpoints and the other for the addition of the included logic. I say this because I'd like to merge in the former and then provide some feedback on the latter.

Thanks again 💯

gregg-platogo and others added 2 commits February 13, 2023 12:01
Co-authored-by: Tomislav Markanovic <tomislav@platogo.com>
Co-authored-by: Tomislav Markanovic <tomislav@platogo.com>
@tmarkanov tmarkanov force-pushed the feature/in-app-purchase-localizations-price-points-management branch from 74aa558 to cd6f00b Compare February 13, 2023 11:01
@tmarkanov
Copy link
Contributor Author

Thanks for your continued contributions to this repo 🎉 I'm wondering if you could split this PR into two separate PRs. One for the added endpoints and the other for the addition of the included logic. I say this because I'd like to merge in the former and then provide some feedback on the latter.

Thanks again 💯

We separated the inclusion code into a new PR.

@kyledecot kyledecot merged commit 2e7014a into kyledecot:main Feb 13, 2023
@gregg-platogo gregg-platogo deleted the feature/in-app-purchase-localizations-price-points-management branch February 13, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants