Module update based on manifests without dependencies to module-manager #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/XXL
szwedm
force-pushed
the
feature/update-based-on-manifests
branch
from
57c4ca4
to
b791b02
Compare
szwedm
requested review from
PK85,
jaroslaw-pieszka,
piotrmiskiewicz,
ralikio,
ukff and
wozniakjan
as code owners
szwedm
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
szwedm
force-pushed
the
feature/update-based-on-manifests
branch
3 times, most recently
from
e64f0c0
to
b651b92
Compare
szwedm
force-pushed
the
feature/update-based-on-manifests
branch
from
b651b92
to
0576dac
Compare
szwedm
commented
Feb 13, 2023
| timeout := time.After(ReadyTimeout) | ||
| for i := 0; i < numOfResources; i++ { | ||
| select { | ||
| case <-resourcesReadinessInformer: |
There was a problem hiding this comment.
WaitGroup doesn't have a timeout
jaroslaw-pieszka
approved these changes
Feb 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Continuation of #98.
This pull request introduces changes in the provisioning and update workflows. It replaces module-manager dependency in favour of a new solution based on manifests rendered from the chart. The reconciler deletes outdated resources listed in
module-resources/delete/to-delete.ymland applies objects fetched from manifests inmodule-resources/apply. The reconciler ensures that specs between manifests and cluster resources stay consistent and doesn't allow any difference between them.Related issue(s)
Closes #148.